[all-commits] [llvm/llvm-project] 5a9e21: [LLDB] Fix crash when printing a struct with a sta...

David Spickett via All-commits all-commits at lists.llvm.org
Fri Oct 7 02:11:32 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5a9e21305803336dc359f72014849845b1a7e173
      https://github.com/llvm/llvm-project/commit/5a9e21305803336dc359f72014849845b1a7e173
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2022-10-07 (Fri, 07 Oct 2022)

  Changed paths:
    M clang/lib/AST/StmtPrinter.cpp
    M lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py
    M lldb/test/API/lang/cpp/const_static_integral_member/main.cpp

  Log Message:
  -----------
  [LLDB] Fix crash when printing a struct with a static signed char member

As with static bool for whatever reason printing them on their own
worked fine but wasn't handled when you printed the whole type.

I don't see a good way to test this from clang's side so our existing
tests will have to do.

We can now print all of the struct "A", so there's no need for a separate
one for static bool testing. I've not checked the output, just that it
succeeds. This saves us having to handle different min/max between systems.

Depends on D135169

Reviewed By: aeubanks, shafik

Differential Revision: https://reviews.llvm.org/D135170




More information about the All-commits mailing list