[all-commits] [llvm/llvm-project] 0da59b: [libc++] Fix wrong implementation of CityHash

Tommy Chiang via All-commits all-commits at lists.llvm.org
Wed Oct 5 13:33:13 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0da59bb8650a37dd6c45d5f7c204634e009c1fc9
      https://github.com/llvm/llvm-project/commit/0da59bb8650a37dd6c45d5f7c204634e009c1fc9
  Author: oToToT <ty1208chiang at gmail.com>
  Date:   2022-10-06 (Thu, 06 Oct 2022)

  Changed paths:
    M libcxx/include/__functional/hash.h
    A libcxx/test/libcxx/utilities/utility/__murmur2_or_cityhash.pass.cpp

  Log Message:
  -----------
  [libc++] Fix wrong implementation of CityHash

As PR56606 stated, the current implementation of CityHash in libc++
would drop some bits unintentionally. Cast the 32bit int to the 64bit
int to avoid this happened.

Reviewed By: ldionne, #libc

Differential Revision: https://reviews.llvm.org/D134124




More information about the All-commits mailing list