[all-commits] [llvm/llvm-project] be758c: [WebAssembly][MC] Fix missing `else` after `return...

Sam Clegg via All-commits all-commits at lists.llvm.org
Tue Oct 4 16:43:40 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: be758cd4a34a2b648a12bb3ae52adf9e6c5472e4
      https://github.com/llvm/llvm-project/commit/be758cd4a34a2b648a12bb3ae52adf9e6c5472e4
  Author: Sam Clegg <sbc at chromium.org>
  Date:   2022-10-04 (Tue, 04 Oct 2022)

  Changed paths:
    M llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.cpp
    A llvm/test/MC/WebAssembly/type-checker-emit-after-unreachable.s

  Log Message:
  -----------
  [WebAssembly][MC] Fix missing `else` after `return` due to type checker bug

Once we are in the `Unreachable` we want to disable type checking, but
we were unconditionally returning `true` here which means we encountered
and error.  Instead we unconditionally return false to signal no error.

Fixes: https://github.com/llvm/llvm-project/issues/56935

Differential Revision: https://reviews.llvm.org/D135195




More information about the All-commits mailing list