[all-commits] [llvm/llvm-project] 8975fb: [mlir] fix DiagnosedSilenceableFailure::takeDiagno...

[ftynse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8975fb0b2647c5f2f0ba6460ca13c02ede109cd3
      https://github.com/llvm/llvm-project/commit/8975fb0b2647c5f2f0ba6460ca13c02ede109cd3
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2022-09-30 (Fri, 30 Sep 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/Transform/IR/TransformInterfaces.h
    M mlir/test/Dialect/Linalg/transform-op-pad.mlir
    M mlir/test/Dialect/Transform/test-interpreter.mlir

  Log Message:
  -----------
  [mlir] fix DiagnosedSilenceableFailure::takeDiagnostics

This function was returning an rvalue reference to an object that was
also cleared via RAII when the function returned, making it always
return an empty object. Make it accept the mutable reference to the
object instead to avoid this dangerous behavior.

Reviewed By: guraypp

Differential Revision: https://reviews.llvm.org/D134948