[all-commits] [llvm/llvm-project] 215c9f: [libc] Re-enable functions from signal.h and re-en...

Siva Chandra via All-commits all-commits at lists.llvm.org
Fri Sep 30 00:32:41 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 215c9fa4deac9ec6b4e504843830551f03b60620
      https://github.com/llvm/llvm-project/commit/215c9fa4deac9ec6b4e504843830551f03b60620
  Author: Siva Chandra Reddy <sivachandra at google.com>
  Date:   2022-09-30 (Fri, 30 Sep 2022)

  Changed paths:
    M libc/config/linux/api.td
    M libc/config/linux/x86_64/entrypoints.txt
    M libc/include/CMakeLists.txt
    M libc/include/llvm-libc-macros/CMakeLists.txt
    M libc/include/llvm-libc-macros/linux/CMakeLists.txt
    A libc/include/llvm-libc-macros/linux/signal-macros.h
    A libc/include/llvm-libc-macros/signal-macros.h
    M libc/include/llvm-libc-types/CMakeLists.txt
    A libc/include/llvm-libc-types/siginfo_t.h
    A libc/include/llvm-libc-types/sigset_t.h
    M libc/include/llvm-libc-types/struct_sigaction.h
    A libc/include/llvm-libc-types/union_sigval.h
    M libc/include/signal.h.def
    M libc/spec/posix.td
    M libc/src/CMakeLists.txt
    M libc/src/signal/linux/CMakeLists.txt
    M libc/src/signal/linux/raise.cpp
    M libc/src/signal/linux/sigaction.cpp
    M libc/src/signal/linux/sigaddset.cpp
    M libc/src/signal/linux/sigdelset.cpp
    M libc/src/signal/linux/sigemptyset.cpp
    M libc/src/signal/linux/sigfillset.cpp
    M libc/src/signal/linux/signal.cpp
    R libc/src/signal/linux/signal.h
    A libc/src/signal/linux/signal_utils.h
    M libc/src/signal/linux/sigprocmask.cpp
    M libc/src/signal/sigaction.h
    M libc/src/signal/sigaddset.h
    M libc/src/stdlib/CMakeLists.txt
    M libc/src/stdlib/linux/CMakeLists.txt
    M libc/test/src/CMakeLists.txt
    M libc/test/src/signal/sigaction_test.cpp
    M libc/test/src/stdlib/CMakeLists.txt

  Log Message:
  -----------
  [libc] Re-enable functions from signal.h and re-enable abort.

They were disabled because we were including linux/signal.h from our
signal.h. Linux's signal.h is not designed to be included from user
programs as it causes a lot of non-standard name pollution. Also, it is
not self-contained. This change defines types and macros relevant for
signal related syscalls within libc's headers and removes inclusion of
Linux headers.

This patch enables the funtions only for x86_64. They will be enabled
for aarch64 also in a follow up patch after testing.

Reviewed By: abrachet, lntue

Differential Revision: https://reviews.llvm.org/D134567




More information about the All-commits mailing list