[all-commits] [llvm/llvm-project] 0fca5c: [mlir][sparse] refactoring SparseTensorUtils: (1 o...

wren romano via All-commits all-commits at lists.llvm.org
Thu Sep 29 14:35:46 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0fca5c5f45c3c290eba5f791ff14596f17162195
      https://github.com/llvm/llvm-project/commit/0fca5c5f45c3c290eba5f791ff14596f17162195
  Author: wren romano <2998727+wrengr at users.noreply.github.com>
  Date:   2022-09-29 (Thu, 29 Sep 2022)

  Changed paths:
    M mlir/include/mlir/ExecutionEngine/Float16bits.h
    A mlir/include/mlir/ExecutionEngine/SparseTensor/COO.h
    A mlir/include/mlir/ExecutionEngine/SparseTensor/CheckedMul.h
    A mlir/include/mlir/ExecutionEngine/SparseTensor/Enums.h
    A mlir/include/mlir/ExecutionEngine/SparseTensor/ErrorHandling.h
    A mlir/include/mlir/ExecutionEngine/SparseTensor/File.h
    A mlir/include/mlir/ExecutionEngine/SparseTensor/Storage.h
    M mlir/include/mlir/ExecutionEngine/SparseTensorUtils.h
    M mlir/lib/Dialect/SparseTensor/Transforms/CodegenUtils.h
    M mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorConversion.cpp
    M mlir/lib/ExecutionEngine/CMakeLists.txt
    M mlir/lib/ExecutionEngine/Float16bits.cpp
    A mlir/lib/ExecutionEngine/SparseTensor/CMakeLists.txt
    A mlir/lib/ExecutionEngine/SparseTensor/File.cpp
    A mlir/lib/ExecutionEngine/SparseTensor/NNZ.cpp
    A mlir/lib/ExecutionEngine/SparseTensor/Storage.cpp
    M mlir/lib/ExecutionEngine/SparseTensorUtils.cpp
    M utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

  Log Message:
  -----------
  [mlir][sparse] refactoring SparseTensorUtils: (1 of 4) file-splitting

Previously, the SparseTensorUtils.cpp library contained a C++ core implementation, but hid it in an anonymous namespace and only exposed a C-API for accessing it. Now we are factoring out that C++ core into a standalone C++ library so that it can be used directly by downstream clients (per request of one such client). This refactoring has been decomposed into a stack of differentials in order to simplify the code review process, however the full stack of changes should be considered together.

* (this): Part 1: split one file into several
* D133830: Part 2: Reorder chunks within files
* D133831: Part 3: General code cleanup
* D133833: Part 4: Update documentation

This part aims to make no changes other than the 1:N file splitting, and things which are forced to accompany that change.

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D133462




More information about the All-commits mailing list