[all-commits] [llvm/llvm-project] 4017d8: When there are variable errors, display an error i...

[Greg Clayton via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4017d86df98faa53bbb1a0acc4e8e58d2b6f2608
      https://github.com/llvm/llvm-project/commit/4017d86df98faa53bbb1a0acc4e8e58d2b6f2608
  Author: Greg Clayton <gclayton at fb.com>
  Date:   2022-09-29 (Thu, 29 Sep 2022)

  Changed paths:
    M lldb/test/API/tools/lldb-vscode/variables/TestVSCode_variables.py
    M lldb/tools/lldb-vscode/lldb-vscode.cpp

  Log Message:
  -----------
  When there are variable errors, display an error in VS Code's local variables view.

After recent diffs that enable variable errors that stop variables from being correctly displayed when debugging, allow users to see these errors in the LOCALS variables in the VS Code UI. We do this by detecting when no variables are available and when there is an error to be displayed, and we add a single variable named "<error>" whose value is a string error that the user can read. This allows the user to be aware of the reason variables are not available and fix the issue. Previously if someone enabled "-gline-tables-only" or was debugging with DWARF in .o files or with .dwo files and those separate object files were missing or they were out of date, the user would see nothing in the variables view. Communicating these errors to the user is essential to a good debugging experience.

Differential Revision: https://reviews.llvm.org/D134333