[all-commits] [llvm/llvm-project] 63acca: [NFC] Refactor DXContainer to support more parts

Chris B via All-commits all-commits at lists.llvm.org
Thu Sep 29 10:15:30 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 63accaf46f09485447a3e2f529eebf2c795a8693
      https://github.com/llvm/llvm-project/commit/63accaf46f09485447a3e2f529eebf2c795a8693
  Author: Chris Bieneman <chris.bieneman at me.com>
  Date:   2022-09-29 (Thu, 29 Sep 2022)

  Changed paths:
    M llvm/include/llvm/BinaryFormat/DXContainer.h
    A llvm/include/llvm/BinaryFormat/DXContainerConstants.def
    M llvm/include/llvm/ObjectYAML/DXContainerYAML.h
    M llvm/lib/BinaryFormat/CMakeLists.txt
    A llvm/lib/BinaryFormat/DXContainer.cpp
    M llvm/lib/Object/DXContainer.cpp
    M llvm/tools/obj2yaml/dxcontainer2yaml.cpp

  Log Message:
  -----------
  [NFC] Refactor DXContainer to support more parts

This patch refactors some of the DXContainer Object and YAML code to
make it easier to add more part parsing.

DXContainer has a whole bunch of constant values, so I've added a
DXContainerConstants.def file which will grow with constant
definitions, but starts with just part identifiers. I've also added a
utility to parse the part magic string into an enum, and converted the
code to use that utility and the enum instead of the part literal
string.

Reviewed By: lhames

Differential Revision: https://reviews.llvm.org/D133980




More information about the All-commits mailing list