[all-commits] [llvm/llvm-project] 682c7c: [AMDGPU] Update `mad-mix*` CodeGen tests

Pierre van Houtryve via All-commits all-commits at lists.llvm.org
Thu Sep 29 00:11:51 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 682c7c77f59a1976353de514057fcaee71937fbc
      https://github.com/llvm/llvm-project/commit/682c7c77f59a1976353de514057fcaee71937fbc
  Author: Pierre van Houtryve <pierre.vanhoutryve at amd.com>
  Date:   2022-09-29 (Thu, 29 Sep 2022)

  Changed paths:
    M llvm/test/CodeGen/AMDGPU/mad-mix-hi.ll
    M llvm/test/CodeGen/AMDGPU/mad-mix-lo.ll
    M llvm/test/CodeGen/AMDGPU/mad-mix.ll

  Log Message:
  -----------
  [AMDGPU] Update `mad-mix*` CodeGen tests

- Use `fneg %a` instead of `fsub -0.0, %a`
  - This is for D134354 as we don't currently support folding `fsub -0.0, %a` into `fneg` on GISel.
    Also, `fneg` is the canonical way to do the negation.
- Switch to `update_llc_test_checks`-generated tests.
  - Better test coverage
  - Easier to update
  - Easier to see changes in future diffs
- Remove unnecessary CL arguments in RUN lines

Motive for the patch: Preparation for D134354 - we would like to
put GISel tests in this file as well. Fixing the lack of `fneg` and
switching to generated testing makes it much easier.

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D134793




More information about the All-commits mailing list