[all-commits] [llvm/llvm-project] 35f258: [amdgpu] Error, instead of miscompile, anonymous k...

[Jon Chesterfield via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 35f2584ef9897ec9e5455ad2660dc1be5171c38c
      https://github.com/llvm/llvm-project/commit/35f2584ef9897ec9e5455ad2660dc1be5171c38c
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2022-09-28 (Wed, 28 Sep 2022)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp
    A llvm/test/CodeGen/AMDGPU/lds-reject-anonymous-kernels.ll
    M llvm/test/CodeGen/AMDGPU/lower-kernel-and-module-lds.ll

  Log Message:
  -----------
  [amdgpu] Error, instead of miscompile, anonymous kernels using lds

The association between kernel and struct is done by symbol name.
This doesn't work robustly for anonymous kernels as shown by the modified
test case.

An alternative association between function and struct can be constructed
if necessary, probably though metadata, but on the basis that we currently
miscompile anonymous kernels and that they are difficult to construct from
application code and difficult to call from the runtime, this patch makes
it a fatal error for now.

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D134741