[all-commits] [llvm/llvm-project] ee8dd4: [libc++] Remove MSVC tests checked into the libc++...

Louis Dionne via All-commits all-commits at lists.llvm.org
Wed Sep 28 05:03:23 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ee8dd43c2407f15c6e757d929f62aee92c9d30a7
      https://github.com/llvm/llvm-project/commit/ee8dd43c2407f15c6e757d929f62aee92c9d30a7
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2022-09-28 (Wed, 28 Sep 2022)

  Changed paths:
    R libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.msvc/test.compile.pass.cpp
    R libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.msvc/test.cpp
    A libcxx/test/std/utilities/utility/forward/forward_like.pass.cpp
    R libcxx/test/std/utilities/utility/forward_like/forward_like.msvc/test.cpp
    R libcxx/test/std/utilities/utility/forward_like/forward_like.msvc/test.pass.cpp

  Log Message:
  -----------
  [libc++] Remove MSVC tests checked into the libc++ test suite

We should strive to have our own tests, except when there is overwhelming
value in using another standard library's existing tests. The reason is
that it ensures that implementations don't all start relying on the same
interpretation of the Standard.

The unique_ptr tests did not add any test coverage AFAICT, and the
forward_like tests were moved to the style used everywhere in the
libc++ test suite.

Note that I got to this because this actually broke a downstream
configuration where we use -ffreestanding. The signature of main()
was not consistent with the signature we (need to) use everywhere
in the test suite.

Differential Revision: https://reviews.llvm.org/D134767




More information about the All-commits mailing list