[all-commits] [llvm/llvm-project] b5bccd: [InstSimplify] add tests for max intrinsic with co...

Sanjay Patel via All-commits all-commits at lists.llvm.org
Mon Sep 26 13:10:00 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b5bccded2c3f293510b3bfe43f82af8b5ba5fae9
      https://github.com/llvm/llvm-project/commit/b5bccded2c3f293510b3bfe43f82af8b5ba5fae9
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
    M llvm/test/Transforms/InstSimplify/maxmin_intrinsics.ll

  Log Message:
  -----------
  [InstSimplify] add tests for max intrinsic with constant expression; NFC

This shows the root problem that leads to the crash in issue #57986.


  Commit: 222e1c73f319560765f1e82ece9be4315e6109c0
      https://github.com/llvm/llvm-project/commit/222e1c73f319560765f1e82ece9be4315e6109c0
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
    M llvm/lib/Analysis/InstructionSimplify.cpp
    M llvm/test/Transforms/InstSimplify/maxmin_intrinsics.ll

  Log Message:
  -----------
  [InstSimplify] don't commute constant expression operand in min/max calls

The test shows that we would fail to consistently fold the
instruction based on the max value operand. This is also
the root cause for issue #57986, but I'll add an instcombine
test + assert for that exact problem in another commit.


  Commit: def6cbd2bd7656a942fe283062ea321ef9a172fc
      https://github.com/llvm/llvm-project/commit/def6cbd2bd7656a942fe283062ea321ef9a172fc
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
    M llvm/test/Transforms/InstCombine/minmax-intrinsics.ll

  Log Message:
  -----------
  [InstCombine] add assert/test for zext to i1

This is a test to verify that we do not crash with the
problem noted in issue #57986. The root problem should
be fixed with a prior change to InstSimplify.


Compare: https://github.com/llvm/llvm-project/compare/8df1f3bc19d7...def6cbd2bd76


More information about the All-commits mailing list