[all-commits] [llvm/llvm-project] c418f0: [lldb] Fix completion of 'settings set' values

Dave Lee via All-commits all-commits at lists.llvm.org
Mon Sep 26 11:26:37 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c418f00536001169f40d09bf3bff568aacfc9c30
      https://github.com/llvm/llvm-project/commit/c418f00536001169f40d09bf3bff568aacfc9c30
  Author: Dave Lee <davelee.com at gmail.com>
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
    M lldb/source/Commands/CommandObjectSettings.cpp
    M lldb/test/API/functionalities/completion/TestCompletion.py

  Log Message:
  -----------
  [lldb] Fix completion of 'settings set' values

Some time ago, a refactor (1153dc960) broke completion for assigning settings
values (`settings set`). This was most annoying for enum settings, where you'd
have to get the valid enum names separately.

This restores the logic in the post-refactor completion function, as well as
adding a test to catch future regressions.

Differential Revision: https://reviews.llvm.org/D134515




More information about the All-commits mailing list