[all-commits] [llvm/llvm-project] 1121ec: [VP][VE] Default VP_SREM/UREM to Expand and add ge...

Craig Topper via All-commits all-commits at lists.llvm.org
Fri Sep 16 13:19:19 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1121eca685a39c1fc370daa65ff918a3cd490dc4
      https://github.com/llvm/llvm-project/commit/1121eca685a39c1fc370daa65ff918a3cd490dc4
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp
    M llvm/lib/CodeGen/TargetLoweringBase.cpp
    M llvm/test/CodeGen/VE/Vector/vp_srem.ll
    M llvm/test/CodeGen/VE/Vector/vp_urem.ll

  Log Message:
  -----------
  [VP][VE] Default VP_SREM/UREM to Expand and add generic expansion using VP_SDIV/UDIV+VP_MUL+VP_SUB.

I want to default all VP operations to Expand. These 2 were blocking
because VE doesn't support them and the tests were expecting them
to fail a specific way. Using Expand caused them to fail differently.

Seemed better to emulate them using operations that are supported.

@simoll mentioned on Discord that VE has some expansion downstream. Not
sure if its done like this or in the VE target.

Reviewed By: frasercrmck, efocht

Differential Revision: https://reviews.llvm.org/D133514




More information about the All-commits mailing list