[all-commits] [llvm/llvm-project] 4e637f: [clang][deps] Make sure ScanInstance outlives coll...

Jan Svoboda via All-commits all-commits at lists.llvm.org
Fri Sep 16 09:44:29 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4e637fcb25503cc9b3bb9af54453ac2ebc7299b1
      https://github.com/llvm/llvm-project/commit/4e637fcb25503cc9b3bb9af54453ac2ebc7299b1
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
    M clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp

  Log Message:
  -----------
  [clang][deps] Make sure ScanInstance outlives collector

The `ScanInstance` is a local variable in `DependencyScanningAction::runInvocation()` that is referenced by `ModuleDepCollector`. Since D132405, `ModuleDepCollector` can escape the function and can outlive its `ScanInstance`. This patch fixes that.

Reviewed By: benlangmuir

Differential Revision: https://reviews.llvm.org/D133988




More information about the All-commits mailing list