[all-commits] [llvm/llvm-project] 57c7bb: [libcxx] Use interface library for libcxx-abi-shared

Nikita Popov via All-commits all-commits at lists.llvm.org
Fri Sep 16 01:13:58 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 57c7bb3ec89565c68f858d316504668f9d214d59
      https://github.com/llvm/llvm-project/commit/57c7bb3ec89565c68f858d316504668f9d214d59
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
    M libcxx/cmake/Modules/HandleLibCXXABI.cmake

  Log Message:
  -----------
  [libcxx] Use interface library for libcxx-abi-shared

The libc++.so linker script generation uses the IMPORTED_LIBNAME
target property on libcxx-abi-shared. However, libcxx-abi-shared
is not an interface library and as such cannot have an
IMPORTED_LIBNAME target property.

Convert libcxx-abi-shared into an imported interface library
and use IMPORTED_LIBNAME in place of IMPORTED_LOCATION. This makes
linker script generation work correctly with system-libcxxabi.

I believe this fixes the issue that D131037 was intended to fix.

Differential Revision: https://reviews.llvm.org/D133566




More information about the All-commits mailing list