[all-commits] [llvm/llvm-project] d6aed7: [InstrProfiling] No runtime hook for unused funcs

[gulfemsavrun via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d6aed77f0d19664be48d531552692520ae2a6f1a
      https://github.com/llvm/llvm-project/commit/d6aed77f0d19664be48d531552692520ae2a6f1a
  Author: Gulfem Savrun Yeniceri <gulfem at google.com>
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
    A clang/test/CoverageMapping/unused_function_no_runtime_hook.cpp
    M llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp

  Log Message:
  -----------
  [InstrProfiling] No runtime hook for unused funcs

This is a reland of https://reviews.llvm.org/D122336.
Original patch caused a problem in collecting coverage in
Fuchsia because it was returning early without putting unused
function names into __llvm_prf_names section. This patch
fixes that issue.

The original commit message is as the following:
CoverageMappingModuleGen generates a coverage mapping record
even for unused functions with internal linkage, e.g.
static int foo() { return 100; }
Clang frontend eliminates such functions, but InstrProfiling pass
still emits runtime hook since there is a coverage record.
Fuchsia uses runtime counter relocation, and pulling in profile
runtime for unused functions causes a linker error:
undefined hidden symbol: __llvm_profile_counter_bias.
Since https://reviews.llvm.org/D98061, we do not hook profile
runtime for the binaries that none of its translation units
have been instrumented in Fuchsia. This patch extends that for
the instrumented binaries that consist of only unused functions.

Reviewed By: phosek

Differential Revision: https://reviews.llvm.org/D122336