[all-commits] [llvm/llvm-project] 5cff32: [MLIR] Fix toy lit substitutions

Christian Sigg via All-commits all-commits at lists.llvm.org
Wed Sep 14 06:59:45 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5cff32b9f0bc7179e7cccb4233968b4a04057e0a
  Author: Christian Sigg <csigg at google.com>
  Date:   2022-09-14 (Wed, 14 Sep 2022)

  Changed paths:
    M mlir/test/lit.cfg.py

  Log Message:
  [MLIR] Fix toy lit substitutions

The tools are called e.g. `toyc-ch1`, not `toy-ch1`.

Add missing toyc-ch6/7.

It turns out that the other substitutions are not needed more by specific circumstances rather than by design:
The lit test exec root is set to build/mlir/test, which is where all the test tools are placed by CMake and we wouldn't need to substitute them at all.
We shouldn't rely on this assumption though, because it will make things harder for standalone tests and other build systems.

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D133842

More information about the All-commits mailing list