[all-commits] [llvm/llvm-project] 3925ea: [lld-macho][nfci] Don't include null terminator in...

Jez Ng via All-commits all-commits at lists.llvm.org
Tue Sep 13 18:25:04 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3925ea4172fa7f9024e5bae8815c01256eea887b
      https://github.com/llvm/llvm-project/commit/3925ea4172fa7f9024e5bae8815c01256eea887b
  Author: Jez Ng <jezng at fb.com>
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
    M lld/MachO/InputSection.cpp
    M lld/MachO/InputSection.h
    M lld/MachO/MapFile.cpp
    M lld/MachO/SyntheticSections.cpp

  Log Message:
  -----------
  [lld-macho][nfci] Don't include null terminator in StringRefs

So @keith observed
[here](https://reviews.llvm.org/D128108#inline-1263900) that the
StringRefs we were returning from `CStringInputSection::getStringRef()`
included the null terminator in their total length, but regular
StringRefs do not. Let's fix that so these StringRefs are less confusing
to use.

Reviewed By: #lld-macho, keith, Roger

Differential Revision: https://reviews.llvm.org/D133728




More information about the All-commits mailing list