[all-commits] [llvm/llvm-project] 5fa6b2: Address feedback in https://reviews.llvm.org/D133637

yozhu via All-commits all-commits at lists.llvm.org
Tue Sep 13 16:13:03 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5fa6b2435477c8d44fc827cda2f998591b1cf837
      https://github.com/llvm/llvm-project/commit/5fa6b2435477c8d44fc827cda2f998591b1cf837
  Author: YongKang Zhu <yongzhu at fb.com>
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
    M llvm/include/llvm/CodeGen/MachineOperand.h
    M llvm/lib/CodeGen/MachineOperand.cpp
    M llvm/lib/CodeGen/MachineStableHash.cpp

  Log Message:
  -----------
  Address feedback in https://reviews.llvm.org/D133637

https://reviews.llvm.org/D133637 fixes the problem where we should hash raw content of
register mask instead of the pointer to it.

Fix the same issue in `llvm::hash_value()`.

Remove the added API `MachineOperand::getRegMaskSize()` to avoid potential confusion.

Add an assert to emphasize that we probably should hash a machine operand iff it has
associated machine function, but keep the fallback logic in the original change.

Reviewed By: MatzeB

Differential Revision: https://reviews.llvm.org/D133747




More information about the All-commits mailing list