[all-commits] [llvm/llvm-project] 3f23eb: Revert "Trying to understand the TestHelp.py failu...

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3f23eb6591bb1eecae38019e8ab1fdf5e2951ae9
      https://github.com/llvm/llvm-project/commit/3f23eb6591bb1eecae38019e8ab1fdf5e2951ae9
  Author: Jim Ingham <jingham at apple.com>
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
    M lldb/source/Interpreter/CommandAlias.cpp

  Log Message:
  -----------
  Revert "Trying to understand the TestHelp.py failure from 6c089b2."

It didn't help.

This reverts commit 81f8788528886ee611041e1f4ee54eea8bbfa277.


  Commit: a2d0a01e3f9941d0d5370890105f70da142f493f
      https://github.com/llvm/llvm-project/commit/a2d0a01e3f9941d0d5370890105f70da142f493f
  Author: Jim Ingham <jingham at apple.com>
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
    M lldb/source/Interpreter/CommandInterpreter.cpp

  Log Message:
  -----------
  Revert "constexpr isn't right here."

This didn't help either.

This reverts commit 8433b210839ed655852428ba8b34bb67b191957a.


  Commit: ac05bc0524c66c74278b26742896a4c634c034cf
      https://github.com/llvm/llvm-project/commit/ac05bc0524c66c74278b26742896a4c634c034cf
  Author: Jim Ingham <jingham at apple.com>
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
    M lldb/include/lldb/Interpreter/CommandInterpreter.h
    M lldb/packages/Python/lldbsuite/test/lldbtest.py
    M lldb/source/Interpreter/CommandAlias.cpp
    M lldb/source/Interpreter/CommandInterpreter.cpp
    M lldb/source/Interpreter/CommandObject.cpp
    M lldb/source/Interpreter/Options.cpp
    M lldb/source/Utility/Args.cpp
    R lldb/test/API/commands/command/backticks/Makefile
    R lldb/test/API/commands/command/backticks/TestBackticksInAlias.py
    R lldb/test/API/commands/command/backticks/main.c

  Log Message:
  -----------
  Revert "Be more careful to maintain quoting information when parsing commands."

This reverts commit 6c089b2af5d8d98f66b27b67f70958f520820a76.

This was causing the test test_help_run_hides_options from TestHelp.py to
fail on Linux and Windows (but the test succeeds on macOS).  The decision
to print option information is determined by CommandObjectAlias::IsDashDashCommand
which was changed, but only by replacing an inline string constant with a const char *
CommandInterpreter::g_argument which has the same string value.  I can't see why this
would fail, I'll have to spin up a vm to see if I can repo there.


Compare: https://github.com/llvm/llvm-project/compare/d8afcaf93e84...ac05bc0524c6