[all-commits] [llvm/llvm-project] 588628: [BOLT] Stop using std::iterator (NFC)

[kazutakahirata via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 588628de3e954d8029b20841aceb612e328ae104
      https://github.com/llvm/llvm-project/commit/588628de3e954d8029b20841aceb612e328ae104
  Author: Kazu Hirata <kazu at google.com>
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
    M bolt/include/bolt/Core/BinaryContext.h
    M bolt/include/bolt/Core/MCPlusBuilder.h
    M bolt/include/bolt/Passes/DataflowAnalysis.h

  Log Message:
  -----------
  [BOLT] Stop using std::iterator (NFC)

Without this patch, I get warnings like:

  bolt/include/bolt/Core/BinaryContext.h:108:19: error:
  'iterator<std::bidirectional_iterator_tag,
  llvm::bolt::BinarySection>' is deprecated
  [-Werror,-Wdeprecated-declarations]

This patch fixes those warnings by defining iterator_category,
value_type, etc.

This patch intentionally leaves duplicate types like FilterIterator::T
and FilterIterator::PointerT intact to avoid mixing the fix and the
cleanup.

Differential Revision: https://reviews.llvm.org/D133650