[all-commits] [llvm/llvm-project] 269423: [flang][runtime] ensure character compares to blan...

jeanPerier via All-commits all-commits at lists.llvm.org
Tue Sep 13 01:43:30 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2694234c2982c57b9442ad1a1b4ffb2100f4ff34
      https://github.com/llvm/llvm-project/commit/2694234c2982c57b9442ad1a1b4ffb2100f4ff34
  Author: Jean Perier <jperier at nvidia.com>
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
    M flang/runtime/character.cpp
    M flang/unittests/Runtime/CharacterTest.cpp

  Log Message:
  -----------
  [flang][runtime] ensure character compares to blank are unsigned

CompareToBlankPadding was doing signed compare on architecture where
`char` is signed. This caused `'abc'//char(128) > 'abc'` to evaluate
to false at runtime instead of true.

Differential Revision: https://reviews.llvm.org/D133693




More information about the All-commits mailing list