[all-commits] [llvm/llvm-project] 241761: [Verifier] Reject dllexport with non-default visib...

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2417618d5ca4b151908df09d8e3a00a49f029222
      https://github.com/llvm/llvm-project/commit/2417618d5ca4b151908df09d8e3a00a49f029222
  Author: Fangrui Song <i at maskray.me>
  Date:   2022-09-05 (Mon, 05 Sep 2022)

  Changed paths:
    M llvm/lib/IR/Verifier.cpp
    M llvm/test/CodeGen/PowerPC/aix-xcoff-exported-nondefault.ll
    M llvm/test/Feature/globalvars.ll
    A llvm/test/Verifier/dllstorage.ll

  Log Message:
  -----------
  [Verifier] Reject dllexport with non-default visibility

Add a visibility check for dllimport and dllexport. Note: dllimport with a
non-default visibility (implicit dso_local) is already rejected, but with a less
clear dso_local error.

The MC level visibility `MCSA_Exported` (D123951) is mapped from IR level
default visibility when dllexport is specified. The D123951 error is now very
difficult to trigger (needs to disable the IR verifier).

Reviewed By: mstorsjo

Differential Revision: https://reviews.llvm.org/D133267