[all-commits] [llvm/llvm-project] 91d832: [MinGW] Reject explicit non-default visibility app...

Fangrui Song via All-commits all-commits at lists.llvm.org
Mon Sep 5 10:17:36 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 91d8324366f405e871aa8174ab61fc66912964dd
      https://github.com/llvm/llvm-project/commit/91d8324366f405e871aa8174ab61fc66912964dd
  Author: Fangrui Song <i at maskray.me>
  Date:   2022-09-05 (Mon, 05 Sep 2022)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticFrontendKinds.td
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/test/CodeGenCXX/dllstorage-visibility.cpp

  Log Message:
  -----------
  [MinGW] Reject explicit non-default visibility applied to dllexport/dllimport declaration

dllimport/dllexport is incompatible with protected/hidden visibilities.
(Arguably dllexport semantics is compatible with protected but let's reject the
combo for simplicity.)

When an explicit visibility attribute applies on a dllexport/dllimport
declaration, report a Frontend error (Sema does not compute visibility).

Reviewed By: mstorsjo

Differential Revision: https://reviews.llvm.org/D133266




More information about the All-commits mailing list