[all-commits] [llvm/llvm-project] f7b752: [lld-macho] Set the SG_READ_ONLY flag on __DATA_CONST

[Daniel Bertalan via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f7b752d27766ecf0241edfbdc4d7142fc40e7621
      https://github.com/llvm/llvm-project/commit/f7b752d27766ecf0241edfbdc4d7142fc40e7621
  Author: Daniel Bertalan <dani at danielbertalan.dev>
  Date:   2022-08-31 (Wed, 31 Aug 2022)

  Changed paths:
    M lld/MachO/OutputSegment.cpp
    M lld/MachO/OutputSegment.h
    M lld/MachO/Writer.cpp
    M lld/test/MachO/builtin-rename.s
    M llvm/include/llvm/BinaryFormat/MachO.h
    M llvm/tools/llvm-objdump/MachODump.cpp

  Log Message:
  -----------
  [lld-macho] Set the SG_READ_ONLY flag on __DATA_CONST

This flag instructs dyld to make the segment read-only after fixups have
been performed.

I'm not sure why this flag is needed, as on macOS 13 beta at least,
__DATA_CONST is read-only even without this flag; but ld64 sets it as
well.

Differential Revision: https://reviews.llvm.org/D133010