[all-commits] [llvm/llvm-project] eaede4: [DAG] extractShiftForRotate - replace assertion fo...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Wed Aug 31 07:51:12 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: eaede4b5b7cfc13ca0e484b4cb25b2f751d86fd9
      https://github.com/llvm/llvm-project/commit/eaede4b5b7cfc13ca0e484b4cb25b2f751d86fd9
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2022-08-31 (Wed, 31 Aug 2022)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    A llvm/test/CodeGen/X86/pr57474.ll

  Log Message:
  -----------
  [DAG] extractShiftForRotate - replace assertion for shift opcode with an early-out

We feed the result from the first extractShiftForRotate call into the second, and that result might no longer be a shift op (usually due to constant folding).

NOTE: We REALLY need to stop creating nodes on the fly inside extractShiftForRotate!

Fixes Issue #57474




More information about the All-commits mailing list