[all-commits] [llvm/llvm-project] 3155e3: [llvm][misexpect] Re-enable MisExpect for SamplePr...

Paul Kirth via All-commits all-commits at lists.llvm.org
Fri Aug 26 13:24:33 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3155e3070c49b31b8d189f5f6caf376fcb82fcfb
      https://github.com/llvm/llvm-project/commit/3155e3070c49b31b8d189f5f6caf376fcb82fcfb
  Author: Paul Kirth <paulkirth at google.com>
  Date:   2022-08-26 (Fri, 26 Aug 2022)

  Changed paths:
    M llvm/lib/Transforms/IPO/SampleProfile.cpp
    M llvm/lib/Transforms/Utils/MisExpect.cpp
    A llvm/test/Transforms/SampleProfile/Inputs/misexpect.prof
    A llvm/test/Transforms/SampleProfile/misexpect-zero.ll
    A llvm/test/Transforms/SampleProfile/misexpect.ll

  Log Message:
  -----------
  [llvm][misexpect] Re-enable MisExpect for SampleProfiling

MisExpect was occasionally crashing under SampleProfiling, due to a division by zero.
We worked around that in D124302 by changing the assert to an early return.
This patch is intended to add a test case for the crashing scenario and
re-enable MisExpect for SampleProfiling.

Reviewed By: tejohnson

Differential Revision: https://reviews.llvm.org/D124481




More information about the All-commits mailing list