[all-commits] [llvm/llvm-project] 471669: [OpenMP] Deprecate the old driver for OpenMP offlo...

[Joseph Huber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 47166968db5c5c677bda996e0c5e40e94d8ef09f
      https://github.com/llvm/llvm-project/commit/47166968db5c5c677bda996e0c5e40e94d8ef09f
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2022-08-26 (Fri, 26 Aug 2022)

  Changed paths:
    M clang/include/clang/Driver/Action.h
    M clang/include/clang/Driver/ToolChain.h
    M clang/lib/Driver/Action.cpp
    M clang/lib/Driver/Driver.cpp
    M clang/lib/Driver/ToolChain.cpp
    M clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp
    M clang/lib/Driver/ToolChains/AMDGPUOpenMP.h
    M clang/lib/Driver/ToolChains/Clang.cpp
    M clang/lib/Driver/ToolChains/Cuda.cpp
    M clang/lib/Driver/ToolChains/Cuda.h
    R clang/test/Driver/amdgpu-openmp-system-arch.c
    R clang/test/Driver/amdgpu-openmp-toolchain-new.c
    M clang/test/Driver/amdgpu-openmp-toolchain.c
    R clang/test/Driver/clang-offload-wrapper.c
    R clang/test/Driver/fat_archive_amdgpu.cpp
    R clang/test/Driver/fat_archive_nvptx.cpp
    R clang/test/Driver/openmp-offload-gpu-new.c
    M clang/test/Driver/openmp-offload-gpu.c
    M clang/test/Driver/openmp-offload.c
    M clang/tools/CMakeLists.txt
    R clang/tools/clang-nvlink-wrapper/CMakeLists.txt
    R clang/tools/clang-nvlink-wrapper/ClangNvlinkWrapper.cpp
    R clang/tools/clang-offload-wrapper/CMakeLists.txt
    R clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp
    M openmp/libomptarget/CMakeLists.txt
    M openmp/libomptarget/test/lit.cfg
    M openmp/libomptarget/test/mapping/data_member_ref.cpp
    M openmp/libomptarget/test/mapping/declare_mapper_nested_default_mappers.cpp
    M openmp/libomptarget/test/mapping/declare_mapper_nested_mappers.cpp
    M openmp/libomptarget/test/mapping/lambda_by_value.cpp
    M openmp/libomptarget/test/mapping/lambda_mapping.cpp
    M openmp/libomptarget/test/mapping/map_back_race.cpp
    M openmp/libomptarget/test/mapping/ompx_hold/struct.c
    M openmp/libomptarget/test/offloading/bug49021.cpp
    M openmp/libomptarget/test/offloading/bug49334.cpp
    M openmp/libomptarget/test/offloading/bug49779.cpp
    M openmp/libomptarget/test/offloading/bug51781.c
    M openmp/libomptarget/test/offloading/host_as_target.c
    M openmp/libomptarget/test/offloading/memory_manager.cpp
    M openmp/libomptarget/test/offloading/parallel_offloading_map.cpp
    M openmp/libomptarget/test/offloading/static_linking.c
    M openmp/libomptarget/test/offloading/taskloop_offload_nowait.cpp
    M openmp/libomptarget/test/unified_shared_memory/api.c

  Log Message:
  -----------
  [OpenMP] Deprecate the old driver for OpenMP offloading

Recently OpenMP has transitioned to using the "new" driver which
primarily merges the device and host linking phases into a single
wrapper that handles both at the same time. This replaced a few tools
that were only used for OpenMP offloading, such as the
`clang-offload-wrapper` and `clang-nvlink-wrapper`. The new driver
carries some marked benefits compared to the old driver that is now
being deprecated. Things like device-side LTO, static library
support, and more compatible tooling. As such, we should be able to
completely deprecate the old driver, at least for OpenMP. The old driver
support will still exist for CUDA and HIP, although both of these can
currently be compiled on Linux with `--offload-new-driver` to use the new
method.

Note that this does not deprecate the `clang-offload-bundler`, although
it is unused by OpenMP now, it is still used by the HIP toolchain both
as their device binary format and object format.

When I proposed deprecating this code I heard some vendors voice
concernes about needing to update their code in their fork. They should
be able to just revert this commit if it lands.

Reviewed By: jdoerfert, MaskRay, ye-luo

Differential Revision: https://reviews.llvm.org/D130020