[all-commits] [llvm/llvm-project] 3dcec5: [LV] Consistently use vputils::isUniformAfterVecto...

Philip Reames via All-commits all-commits at lists.llvm.org
Fri Aug 26 11:09:38 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3dcec5e29ff73d9f42b364885119105b69c2bb37
      https://github.com/llvm/llvm-project/commit/3dcec5e29ff73d9f42b364885119105b69c2bb37
  Author: Philip Reames <preames at rivosinc.com>
  Date:   2022-08-26 (Fri, 26 Aug 2022)

  Changed paths:
    M llvm/lib/Transforms/Vectorize/LoopVectorize.cpp

  Log Message:
  -----------
  [LV] Consistently use vputils::isUniformAfterVectorization [mostly nfc]

I'd extracted isUniform, and Florian moved isUniformAfterVectorization out of VPlan at basically the same time. Let's go ahead and merge them.

For the VPTransformState::get path, a VPValue without a def (which corresponds to an external IR value outside of VPLan) is explicitly handled above the uniform check.  On the scalarizeInstruction path, I'm less sure why the change isn't visible, but test cases which would seem likely to hit it were already being handled as uniform through some other mechanism.  It would be correct to consider values defined outside of vplan uniform here.




More information about the All-commits mailing list