[all-commits] [llvm/llvm-project] 0483b0: Mark the $local function begin symbol as a function

[Alexander Richardson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0483b008759b566984f040269b7a90210922a145
      https://github.com/llvm/llvm-project/commit/0483b008759b566984f040269b7a90210922a145
  Author: Alex Richardson <alexrichardson at google.com>
  Date:   2022-08-26 (Fri, 26 Aug 2022)

  Changed paths:
    M llvm/include/llvm/CodeGen/AsmPrinter.h
    M llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
    M llvm/test/CodeGen/AArch64/elf-preemption.ll
    M llvm/test/CodeGen/AArch64/semantic-interposition-asm.ll
    M llvm/test/CodeGen/ARM/dso-local-func.ll
    M llvm/test/CodeGen/ARM/thumb-function-section-reloc.ll
    M llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/amdgpu_generated_funcs.ll.generated.expected
    M llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/amdgpu_generated_funcs.ll.nogenerated.expected
    M llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/lanai_generated_funcs.ll.generated.expected
    M llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/lanai_generated_funcs.ll.nogenerated.expected
    M llvm/utils/UpdateTestChecks/asm.py

  Log Message:
  -----------
  Mark the $local function begin symbol as a function

While this does not matter for most targets, when building for Arm Morello,
we have to mark the symbol as a function and add size information, so that
LLD can correctly evaluate relocations against the local symbol.
Since Morello is an out-of-tree target, I tried to reproduce this with
in-tree backends and with the previous reviews applied this results in
a noticeable difference when targeting Thumb.

Background: Morello uses a method similar Thumb where the encoding mode is
specified in the LSB of the symbol. If we don't mark the target as a
function, the relocation will not have the LSB set and calls will end up
using the wrong encoding mode (which will almost certainly crash).

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D131429


  Commit: df00dac828d7d0f88106d34b12a4eafaa8dd93ea
      https://github.com/llvm/llvm-project/commit/df00dac828d7d0f88106d34b12a4eafaa8dd93ea
  Author: Alex Richardson <alexrichardson at google.com>
  Date:   2022-08-26 (Fri, 26 Aug 2022)

  Changed paths:
    M llvm/lib/Target/ARM/ARMAsmPrinter.cpp
    M llvm/test/CodeGen/ARM/dso-local-func.ll
    M llvm/test/CodeGen/ARM/elf-preemption.ll
    M llvm/test/CodeGen/ARM/thumb-function-section-reloc.ll

  Log Message:
  -----------
  [ARM] Use getSymbolPreferLocal() in GetARMGVSymbol

This allows relaxing some relocations to symbol+offset instead of emitting
a relocation against a symbol.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D131433


Compare: https://github.com/llvm/llvm-project/compare/5955edf8a453...df00dac828d7