[all-commits] [llvm/llvm-project] 51d825: ManagedStatic: remove from DebugCounter

[Nicolai Hähnle via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 51d82502d98d3c5d60606e63b6c23bb5759fdb91
      https://github.com/llvm/llvm-project/commit/51d82502d98d3c5d60606e63b6c23bb5759fdb91
  Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
  Date:   2022-08-25 (Thu, 25 Aug 2022)

  Changed paths:
    M llvm/include/llvm/Support/DebugCounter.h
    M llvm/lib/Support/DebugCounter.cpp

  Log Message:
  -----------
  ManagedStatic: remove from DebugCounter

Follow the pattern used in MLIR for the cl::opt instances.

v2:
- make DebugCounter::isCountingEnabled public so that the
  DebugCounterOwner doesn't have to be a nested class. This simplifies
  later changes

Differential Revision: https://reviews.llvm.org/D129116


  Commit: af2e54992de969f3ec75e397f1840068c2ebd060
      https://github.com/llvm/llvm-project/commit/af2e54992de969f3ec75e397f1840068c2ebd060
  Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
  Date:   2022-08-25 (Thu, 25 Aug 2022)

  Changed paths:
    M llvm/include/llvm/Support/Timer.h
    M llvm/lib/Support/Statistic.cpp
    M llvm/lib/Support/Timer.cpp

  Log Message:
  -----------
  [Timer][Statistics] Make global constructor ordering more robust

It was observed in D129117 that the subtle dependency between statistic
and timer code is not entirely robust: the global destructor
~StatisticInfo indirectly calls CreateInfoOutputFile, which requires
the LibSupportInfoOutputFilename to not have been destructed.

By constructing LibSupportInfoOutputFilename before the StatisticInfo
object, the order of destruction is guaranteed.

Differential Revision: https://reviews.llvm.org/D131059


Compare: https://github.com/llvm/llvm-project/compare/0393443bf806...af2e54992de9