[all-commits] [llvm/llvm-project] 096463: [libc] move printf to use StringViews

michaelrj-google via All-commits all-commits at lists.llvm.org
Wed Aug 24 10:28:50 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 096463d08eaa053c000700c3d4648f0c93cb7af6
      https://github.com/llvm/llvm-project/commit/096463d08eaa053c000700c3d4648f0c93cb7af6
  Author: Michael Jones <michaelrj at google.com>
  Date:   2022-08-24 (Wed, 24 Aug 2022)

  Changed paths:
    M libc/src/stdio/printf_core/CMakeLists.txt
    M libc/src/stdio/printf_core/char_converter.h
    M libc/src/stdio/printf_core/converter.cpp
    M libc/src/stdio/printf_core/core_structs.h
    M libc/src/stdio/printf_core/file_writer.cpp
    M libc/src/stdio/printf_core/file_writer.h
    M libc/src/stdio/printf_core/float_hex_converter.h
    M libc/src/stdio/printf_core/float_inf_nan_converter.h
    M libc/src/stdio/printf_core/int_converter.h
    M libc/src/stdio/printf_core/parser.cpp
    M libc/src/stdio/printf_core/parser.h
    M libc/src/stdio/printf_core/printf_main.cpp
    M libc/src/stdio/printf_core/ptr_converter.h
    M libc/src/stdio/printf_core/string_converter.h
    M libc/src/stdio/printf_core/string_writer.cpp
    M libc/src/stdio/printf_core/string_writer.h
    M libc/src/stdio/printf_core/vfprintf_internal.cpp
    M libc/src/stdio/printf_core/writer.cpp
    M libc/src/stdio/printf_core/writer.h
    M libc/src/stdio/snprintf.cpp
    M libc/src/stdio/sprintf.cpp
    M libc/test/src/stdio/printf_core/CMakeLists.txt
    M libc/test/src/stdio/printf_core/converter_test.cpp
    M libc/test/src/stdio/printf_core/parser_test.cpp
    M libc/test/src/stdio/printf_core/string_writer_test.cpp
    M libc/utils/UnitTest/CMakeLists.txt
    M libc/utils/UnitTest/PrintfMatcher.cpp

  Log Message:
  -----------
  [libc] move printf to use StringViews

The FormatSection and the writer functions both previously took a char*
and a length to represent a string. Now they use the StringView class to
represent that more succinctly. This change also required fixing
everywhere these were used, so it touches a lot of files.

Reviewed By: sivachandra

Differential Revision: https://reviews.llvm.org/D131994




More information about the All-commits mailing list