[all-commits] [llvm/llvm-project] 8ccca3: [InstCombine] adjust tests for mul+add common fact...

[Sanjay Patel via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8ccca3f3a4982970eecbb4fc8513cd26a585ec36
      https://github.com/llvm/llvm-project/commit/8ccca3f3a4982970eecbb4fc8513cd26a585ec36
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-08-23 (Tue, 23 Aug 2022)

  Changed paths:
    M llvm/test/Transforms/InstCombine/add.ll

  Log Message:
  -----------
  [InstCombine] adjust tests for mul+add common factor; NFC

The existing tests were added with 2880d7b9e4c9a0, but
discussion in D132412 suggests that we should start
with a simpler pattern (the more complicated pattern
may not be a real problem).


  Commit: 7d670976dbb03dc9c36f5c9edba81990ad6e2580
      https://github.com/llvm/llvm-project/commit/7d670976dbb03dc9c36f5c9edba81990ad6e2580
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-08-23 (Tue, 23 Aug 2022)

  Changed paths:
    M llvm/test/CodeGen/AArch64/arm64-popcnt.ll

  Log Message:
  -----------
  [AArch64] add test for popcount i32; NFC

More coverage for D132237


  Commit: f8dfbea3249e8304811b1d991e4d6bb362a9b6d6
      https://github.com/llvm/llvm-project/commit/f8dfbea3249e8304811b1d991e4d6bb362a9b6d6
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-08-23 (Tue, 23 Aug 2022)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
    M llvm/test/CodeGen/AArch64/arm64-popcnt.ll

  Log Message:
  -----------
  [SDAG] expand more is-power-of-2 patterns that use popcount

(ctpop x) == 1 --> (x != 0) && ((x & x-1) == 0)

Adjust the legality check to avoid the poor codegen on AArch64.
We probably only want to use popcount on this pattern when it
is a single instruction.

fixes #57225

Differential Revision: https://reviews.llvm.org/D132237


Compare: https://github.com/llvm/llvm-project/compare/89476dbca18c...f8dfbea3249e