[all-commits] [llvm/llvm-project] 0565e6: [clang/test] Correctly specify simulator env in ta...

[Nico Weber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0565e65a69676a75a9da89c35d2ceda2ef4d21f7
      https://github.com/llvm/llvm-project/commit/0565e65a69676a75a9da89c35d2ceda2ef4d21f7
  Author: Nico Weber <thakis at chromium.org>
  Date:   2022-08-23 (Tue, 23 Aug 2022)

  Changed paths:
    M clang/test/Driver/fsanitize.c

  Log Message:
  -----------
  [clang/test] Correctly specify simulator env in target flag in fsanitize.c

Putting "simulator" in the `-target` flag requires putting it in the
"environment" part of the triple, which is the 4th `-`-separated component.

Some places in the tests currently use "iossimulator" which puts it in the
OS field. The triple parsing code in llvm::Triple uses startswith("ios")
in parseOS(), so that successfully sets the OS to "iOS", and all these
triples use an intel arch, and iOS + intel triple implicitly make the
driver convert the environment to "simulator", so this happened to work --
but it led to the somewhat strange "simulator-simulator" in the diag
in the test.

No behavior change.

Differential Revision: https://reviews.llvm.org/D132399