[all-commits] [llvm/llvm-project] c21dfa: [lldb] Remove prefer-dynamic-value test override

[Dave Lee via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c21dfa9e4931a0a339813a5d384fc2eb0deee235
      https://github.com/llvm/llvm-project/commit/c21dfa9e4931a0a339813a5d384fc2eb0deee235
  Author: Dave Lee <davelee.com at gmail.com>
  Date:   2022-08-22 (Mon, 22 Aug 2022)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/configuration.py
    M lldb/test/API/commands/expression/po_verbosity/TestPoVerbosity.py
    M lldb/test/API/commands/expression/two-files/TestObjCTypeQueryFromOtherCompileUnit.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCCF.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCExpr.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCKVO.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSContainer.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSData.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSNumber.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/nsstring/TestDataFormatterNSString.py
    M lldb/test/API/functionalities/data-formatter/nsarraysynth/TestNSArraySynthetic.py
    M lldb/test/API/functionalities/data-formatter/nsdictionarysynth/TestNSDictionarySynthetic.py
    M lldb/test/API/lang/cpp/diamond/TestCppDiamond.py
    M lldb/test/API/lang/objc/blocks/TestObjCIvarsInBlocks.py
    M lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py
    M lldb/test/API/lang/objc/foundation/TestObjCMethods.py
    M lldb/test/API/lang/objc/foundation/TestObjCMethodsString.py
    M lldb/test/API/lang/objc/foundation/TestRuntimeTypes.py
    M lldb/test/API/lang/objc/objc-new-syntax/TestObjCNewSyntaxLiteral.py
    M lldb/test/API/lang/objc/real-definition/TestRealDefinition.py
    M lldb/test/API/sanity/TestSettingSkipping.py

  Log Message:
  -----------
  [lldb] Remove prefer-dynamic-value test override

Remove the test override of `target.prefer-dynamic-value`.

Previously, the lldb default was `no-dynamic-values`. In rG9aa7e8e9ffbe (in
2015), the default was changed to `no-run-target`, but at that time the tests
were changed to be run with `no-dynamic-value`. I don't know the reasons for
not changing the tests, perhaps to avoid determining which tests to change, and
what about them to change.

Because `no-run-target` is the lldb default, I think it makes sense to make it
the test default too. It puts the test config closer to what's used in
practice.

This change removes the `target.prefer-dynamic-value` override, and for those
tests that failed, they have been updated to explicitly use
`no-dynamic-values`. Future changes could update these tests to use dynamic
values too, or they can be left as is to exercise non-dynamic typing.

Differential Revision: https://reviews.llvm.org/D132382