[all-commits] [llvm/llvm-project] 08cc03: [mlir][spirv] Clean up SPIRVOps.cpp. NFC.

Jakub Kuderski via All-commits all-commits at lists.llvm.org
Tue Aug 9 07:42:10 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 08cc03befd44c1157fa5b5586c1a9861a5869203
  Author: Jakub Kuderski <kubak at google.com>
  Date:   2022-08-09 (Tue, 09 Aug 2022)

  Changed paths:
    M mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp

  Log Message:
  [mlir][spirv] Clean up SPIRVOps.cpp. NFC.

Resolve almost all clang tidy warnings in this file:
1. Clean up string constants.
2. Use consistent argument names across function declarations and definitions. Rename `state` - > `result`, which is consistent with the other dialects.
3. Remove misleading function parameter name comments (`argTypes`). This did not match the actual function argument (`bool enableNameShadowing`).
4. Simplify calls to `is_splat`.

Reviewed By: antiagainst

Differential Revision: https://reviews.llvm.org/D131297

More information about the All-commits mailing list