[all-commits] [llvm/llvm-project] ee168f: [mlir][python] Fix issues with block argument slices

ftynse via All-commits all-commits at lists.llvm.org
Thu Jul 21 07:41:25 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ee168fb90e4f3321037dcc2c8cb82497a70db92e
      https://github.com/llvm/llvm-project/commit/ee168fb90e4f3321037dcc2c8cb82497a70db92e
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2022-07-21 (Thu, 21 Jul 2022)

  Changed paths:
    M mlir/lib/Bindings/Python/IRAffine.cpp
    M mlir/lib/Bindings/Python/IRCore.cpp
    M mlir/lib/Bindings/Python/PybindUtils.h
    M mlir/test/python/ir/operation.py

  Log Message:
  -----------
  [mlir][python] Fix issues with block argument slices

The type extraction helper function for block argument and op result
list objects was ignoring the slice entirely. So was the slice addition.
Both are caused by a misleading naming convention to implement slices
via CRTP. Make the convention more explicit and hide the helper
functions so users have harder time calling them directly.

Closes #56540.

Reviewed By: stellaraccident

Differential Revision: https://reviews.llvm.org/D130271




More information about the All-commits mailing list