[all-commits] [llvm/llvm-project] 251165: [lldb] [test] Use raise(SIGSTOP) instead of trap i...

Michał Górny via All-commits all-commits at lists.llvm.org
Wed Jun 29 06:38:39 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 251165b2e48216f8fbeef1960711219afac406f4
      https://github.com/llvm/llvm-project/commit/251165b2e48216f8fbeef1960711219afac406f4
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2022-06-29 (Wed, 29 Jun 2022)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/tools/lldb-server/fork_testbase.py
    M lldb/test/API/tools/lldb-server/TestGdbRemoteFork.py
    M lldb/test/API/tools/lldb-server/TestGdbRemoteForkNonStop.py
    M lldb/test/API/tools/lldb-server/main.cpp

  Log Message:
  -----------
  [lldb] [test] Use raise(SIGSTOP) instead of trap in fork tests

Replace the use of "trap" with a new "stop" command in fork tests,
that maps to `raise(SIGSTOP)`.  Since traps do not increment PC on some
architectures (notably ARM), using traps would require special logic
to increment it while testing.  Using SIGSTOP avoids the problem
and is probably more logical, given that the purpose of the "trap"s
was to simply stop the inferior at a synchronization point.  This fixes
tests on AArch64 (and possibly ARM, I'll update XFAILs when it is
confirmed by the buildbot).

Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.llvm.org/D128780




More information about the All-commits mailing list