[all-commits] [llvm/llvm-project] 56ab96: [CUDA] Stop adding CUDA features twice

Joseph Huber via All-commits all-commits at lists.llvm.org
Wed Jun 29 06:34:31 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 56ab966a04dd22570fcb18276e2409c94e82c571
      https://github.com/llvm/llvm-project/commit/56ab966a04dd22570fcb18276e2409c94e82c571
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2022-06-29 (Wed, 29 Jun 2022)

  Changed paths:
    M clang/lib/Driver/ToolChains/Cuda.cpp
    M clang/lib/Driver/ToolChains/Cuda.h

  Log Message:
  -----------
  [CUDA] Stop adding CUDA features twice

We currently call the `addNVPTXFeatures` function in two places, inside
of the CUDA Toolchain and inside of Clang in the standard entry point.
We normally add features to the job in Clang, so the call inside of the
CUDA toolchain is redundant and results in `+ptx` features being added.
Since we remove this call, we no longer will have a cached CUDA
installation so we will usually create it twice.

Reviewed By: tra

Differential Revision: https://reviews.llvm.org/D128752




More information about the All-commits mailing list