[all-commits] [llvm/llvm-project] b2cb7e: [clang-tidy] cppcoreguidelines-virtual-class-destr...

Richard Thomson via All-commits all-commits at lists.llvm.org
Sat Jun 25 15:19:22 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b2cb7e81f8978ccce5c5e7b316480b88785ca9cc
      https://github.com/llvm/llvm-project/commit/b2cb7e81f8978ccce5c5e7b316480b88785ca9cc
  Author: Joachim Priesner <llvm-project-704996 at jspam.de>
  Date:   2022-06-25 (Sat, 25 Jun 2022)

  Changed paths:
    M clang-tools-extra/clang-tidy/cppcoreguidelines/VirtualClassDestructorCheck.cpp
    M clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/virtual-class-destructor.cpp

  Log Message:
  -----------
  [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

Check llvm::Optional before dereferencing it.

Compute VirtualEndLoc differently to avoid an assertion failure
in clang::SourceManager::getFileIDLoaded:

Assertion `0 && "Invalid SLocOffset or bad function choice"' failed




More information about the All-commits mailing list