[all-commits] [llvm/llvm-project] dc9788: [flang] Restore Optional::value() (NFC)

kazutakahirata via All-commits all-commits at lists.llvm.org
Sat Jun 25 13:21:48 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dc97886fa36df582ed8957d13e4e51321507dc18
      https://github.com/llvm/llvm-project/commit/dc97886fa36df582ed8957d13e4e51321507dc18
  Author: Kazu Hirata <kazu at google.com>
  Date:   2022-06-25 (Sat, 25 Jun 2022)

  Changed paths:
    M flang/lib/Lower/ConvertExpr.cpp
    M flang/lib/Optimizer/CodeGen/CodeGen.cpp

  Log Message:
  -----------
  [flang] Restore Optional::value() (NFC)

This patch restores several calls to Optional::value() in preference
to Optional::operator*.

The Flang C++ Style Guide tells us to use x.value() where no presence
test is obviously protecting a *x reference to the contents.

Differential Revision: https://reviews.llvm.org/D128590




More information about the All-commits mailing list