[all-commits] [llvm/llvm-project] c119a1: [AST] Fix clang RecursiveASTVisitor for definition...

Daiyousei via All-commits all-commits at lists.llvm.org
Sun Jun 5 23:35:49 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c119a17e7fd6fb528d8c1e1bbb0ad1fac93f896a
      https://github.com/llvm/llvm-project/commit/c119a17e7fd6fb528d8c1e1bbb0ad1fac93f896a
  Author: Qingyuan Zheng <qyzheng2 at outlook.com>
  Date:   2022-06-06 (Mon, 06 Jun 2022)

  Changed paths:
    M clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp
    M clang/include/clang/AST/RecursiveASTVisitor.h

  Log Message:
  -----------
  [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl

Fixes https://github.com/clangd/clangd/issues/1132
where clangd's semantic highlighting is missing for symbols of a template
specialization definition. It turns out the visitor didn't traverse the
base classes of Class/Var##TemplateSpecializationDecl, i.e.
CXXRecordDecl/VarDecl. This patch adds them back as what is done in
DEF_TRAVERSE_TMPL_PART_SPEC_DECL.

Reviewed By: rsmith

Differential Revision: https://reviews.llvm.org/D126757




More information about the All-commits mailing list