[all-commits] [llvm/llvm-project] bd93df: [Polly] Mark classes as final by default. NFC.

[Michael Kruse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bd93df937a6441db4aff67191ca0bb486554c34b
      https://github.com/llvm/llvm-project/commit/bd93df937a6441db4aff67191ca0bb486554c34b
  Author: Michael Kruse <llvm-project at meinersbur.de>
  Date:   2022-05-17 (Tue, 17 May 2022)

  Changed paths:
    M llvm/include/llvm/Analysis/DOTGraphTraitsPass.h
    M polly/include/polly/CodeGen/BlockGenerators.h
    M polly/include/polly/CodeGen/CodeGeneration.h
    M polly/include/polly/CodeGen/IRBuilder.h
    M polly/include/polly/CodeGen/IslAst.h
    M polly/include/polly/CodeGen/IslExprBuilder.h
    M polly/include/polly/CodeGen/LoopGeneratorsGOMP.h
    M polly/include/polly/CodeGen/LoopGeneratorsKMP.h
    M polly/include/polly/CodeGen/PerfMonitor.h
    M polly/include/polly/CodePreparation.h
    M polly/include/polly/DeLICM.h
    M polly/include/polly/DeadCodeElimination.h
    M polly/include/polly/DependenceInfo.h
    M polly/include/polly/ForwardOpTree.h
    M polly/include/polly/JSONExporter.h
    M polly/include/polly/ManualOptimizer.h
    M polly/include/polly/MatmulOptimizer.h
    M polly/include/polly/PolyhedralInfo.h
    M polly/include/polly/PruneUnprofitable.h
    M polly/include/polly/ScheduleOptimizer.h
    M polly/include/polly/ScheduleTreeTransform.h
    M polly/include/polly/ScopBuilder.h
    M polly/include/polly/ScopDetection.h
    M polly/include/polly/ScopDetectionDiagnostic.h
    M polly/include/polly/ScopGraphPrinter.h
    M polly/include/polly/ScopInfo.h
    M polly/include/polly/ScopPass.h
    M polly/include/polly/Simplify.h
    M polly/include/polly/Support/DumpFunctionPass.h
    M polly/include/polly/Support/DumpModulePass.h
    M polly/include/polly/Support/GICHelper.h
    M polly/include/polly/Support/ISLTools.h
    M polly/include/polly/Support/SCEVAffinator.h
    M polly/include/polly/Support/ScopHelper.h
    M polly/include/polly/Support/VirtualInstruction.h
    M polly/lib/Analysis/DependenceInfo.cpp
    M polly/lib/Analysis/PolyhedralInfo.cpp
    M polly/lib/Analysis/PruneUnprofitable.cpp
    M polly/lib/Analysis/ScopDetection.cpp
    M polly/lib/Analysis/ScopGraphPrinter.cpp
    M polly/lib/Analysis/ScopInfo.cpp
    M polly/lib/CodeGen/CodeGeneration.cpp
    M polly/lib/CodeGen/CodegenCleanup.cpp
    M polly/lib/CodeGen/IslAst.cpp
    M polly/lib/CodeGen/IslNodeBuilder.cpp
    M polly/lib/CodeGen/ManagedMemoryRewrite.cpp
    M polly/lib/CodeGen/PPCGCodeGeneration.cpp
    M polly/lib/Exchange/JSONExporter.cpp
    M polly/lib/Support/DumpFunctionPass.cpp
    M polly/lib/Support/DumpModulePass.cpp
    M polly/lib/Support/RegisterPasses.cpp
    M polly/lib/Support/SCEVValidator.cpp
    M polly/lib/Support/ScopHelper.cpp
    M polly/lib/Transform/Canonicalization.cpp
    M polly/lib/Transform/CodePreparation.cpp
    M polly/lib/Transform/DeLICM.cpp
    M polly/lib/Transform/DeadCodeElimination.cpp
    M polly/lib/Transform/FlattenSchedule.cpp
    M polly/lib/Transform/ForwardOpTree.cpp
    M polly/lib/Transform/ManualOptimizer.cpp
    M polly/lib/Transform/MatmulOptimizer.cpp
    M polly/lib/Transform/MaximalStaticExpansion.cpp
    M polly/lib/Transform/ScheduleOptimizer.cpp
    M polly/lib/Transform/ScheduleTreeTransform.cpp
    M polly/lib/Transform/ScopInliner.cpp
    M polly/lib/Transform/Simplify.cpp

  Log Message:
  -----------
  [Polly] Mark classes as final by default. NFC.

This make is obivious that a class was not intended to be derived from.

NPM analysis pass can unfortunately not marked as final because they are
derived from a llvm::Checker<T> template internally by the NPM.

Also normalize the use of classes/structs
 * NPM passes are structs
 * Legacy passes are classes
 * structs that have methods and are not a visitor pattern are classes
 * structs have public inheritance by default, remove "public" keyword
 * Use typedef'ed type instead of inline forward declaration