[all-commits] [llvm/llvm-project] 5fdfcf: [InstCombine] update auto-generated CHECK lines in...

Sanjay Patel via All-commits all-commits at lists.llvm.org
Wed May 11 11:09:22 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5fdfcf489264fea9840fd70536b79cdcd22b1c0d
      https://github.com/llvm/llvm-project/commit/5fdfcf489264fea9840fd70536b79cdcd22b1c0d
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-05-11 (Wed, 11 May 2022)

  Changed paths:
    M llvm/test/Transforms/InstCombine/div.ll

  Log Message:
  -----------
  [InstCombine] update auto-generated CHECK lines in test file; NFC

These are all cosmetic (value naming) diffs that would distract from
real changes in this file.


  Commit: 99ef341ce9436e0471eb5502a8521fcaddaf851c
      https://github.com/llvm/llvm-project/commit/99ef341ce9436e0471eb5502a8521fcaddaf851c
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-05-11 (Wed, 11 May 2022)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
    M llvm/test/Transforms/InstCombine/div.ll

  Log Message:
  -----------
  [InstCombine] freeze operand in sdiv expansion

As discussed in issue #37809, this transform is not safe
if the input is an undefined value.

This is similar to a recent change for urem:
d428f09b2c9d

There is no difference in codegen on the basic examples,
but this could lead to regressions. We may need to
improve freeze analysis or lowering if that happens.

Presumably, in real cases that are similar to the tests
where a subsequent transform removes the select, we
will also be able to remove the freeze by seeing that
the parameter has 'noundef'.


Compare: https://github.com/llvm/llvm-project/compare/078174278574...99ef341ce943


More information about the All-commits mailing list