[all-commits] [llvm/llvm-project] 5017de: [builtins] Do not force thumb mode directive in ar...

Khem Raj via All-commits all-commits at lists.llvm.org
Fri Mar 11 16:26:03 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5017de8ba4b1fe985169cf54590e858a9019a91f
      https://github.com/llvm/llvm-project/commit/5017de8ba4b1fe985169cf54590e858a9019a91f
  Author: Khem Raj <raj.khem at gmail.com>
  Date:   2022-03-11 (Fri, 11 Mar 2022)

  Changed paths:
    M compiler-rt/lib/builtins/arm/sync-ops.h

  Log Message:
  -----------
  [builtins] Do not force thumb mode directive in arm/sync-ops.h

.thumb_func was not switching mode until [1]
so it did not show up but now that .thumb_func (without argument) is
switching mode, its causing build failures on armv6 ( rpi0 ) even when
build is explicitly asking for this file to be built with -marm (ARM
mode), therefore use DEFINE_COMPILERRT_FUNCTION macro to add function
header which considers arch and mode from compiler cmdline to decide if
the function is built using thumb mode or arm mode.

[1] https://reviews.llvm.org/D101975

Note that it also needs https://reviews.llvm.org/D99282

Reviewed By: peter.smith, MaskRay

Differential Revision: https://reviews.llvm.org/D104183




More information about the All-commits mailing list