[all-commits] [llvm/llvm-project] b24de9: [mlir] ExecutionEngine: default enableObjectCache ...

[Emilio Cota via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b24de9f6845217f03014a36814d61f4ed91f0405
      https://github.com/llvm/llvm-project/commit/b24de9f6845217f03014a36814d61f4ed91f0405
  Author: Emilio Cota <ecg at google.com>
  Date:   2022-03-10 (Thu, 10 Mar 2022)

  Changed paths:
    M mlir/include/mlir/ExecutionEngine/ExecutionEngine.h
    M mlir/lib/ExecutionEngine/ExecutionEngine.cpp
    M mlir/lib/ExecutionEngine/JitRunner.cpp

  Log Message:
  -----------
  [mlir] ExecutionEngine: default enableObjectCache to false

The enableObjectCache option was added in
https://reviews.llvm.org/rG06e8101034e, defaulting to false. However,
the init code added there got its logic reversed
(cache(enableObjectCache ? nullptr : new SimpleObjectCache()), which was
fixed in https://reviews.llvm.org/rGd1186fcb04 by setting the default to
true, thereby preserving the existing behavior even if it was
unintentional.

Default now the object cache to false as it was originally intended.
While at it, mention in enableObjectCache's documentation how the
cache can be dumped.

Reviewed-by: mehdi_amini
Differential Revision: https://reviews.llvm.org/D121291