[all-commits] [llvm/llvm-project] cc8f98: [InstCombine] add tests to show miscompiled smin/s...

Sanjay Patel via All-commits all-commits at lists.llvm.org
Wed Mar 9 14:52:42 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cc8f98198799fe3a5f00e2fc0edcb5d90c124d2f
      https://github.com/llvm/llvm-project/commit/cc8f98198799fe3a5f00e2fc0edcb5d90c124d2f
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-03-09 (Wed, 09 Mar 2022)

  Changed paths:
    M llvm/test/Transforms/InstCombine/select-min-max.ll

  Log Message:
  -----------
  [InstCombine] add tests to show miscompiled smin/smax; NFC


  Commit: b48fe158e0a8d77fd3e28e90e512589601680ad8
      https://github.com/llvm/llvm-project/commit/b48fe158e0a8d77fd3e28e90e512589601680ad8
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-03-09 (Wed, 09 Mar 2022)

  Changed paths:
    M llvm/lib/Analysis/ValueTracking.cpp
    M llvm/test/CodeGen/X86/vec_minmax_match.ll
    M llvm/test/Transforms/InstCombine/select-min-max.ll
    M llvm/test/Transforms/LoopVectorize/bzip_reverse_loops.ll
    M llvm/test/Transforms/PhaseOrdering/min-max-abs-cse.ll

  Log Message:
  -----------
  [Analysis] remove bogus smin/smax pattern detection

This is a revert of cfcc42bdc. The analysis is wrong as shown by
the minimal tests for instcombine:
https://alive2.llvm.org/ce/z/y9Dp8A

There may be a way to salvage some of the other tests,
but that can be done as follow-ups. This avoids a miscompile
and fixes #54311.


Compare: https://github.com/llvm/llvm-project/compare/0be6fd44f363...b48fe158e0a8


More information about the All-commits mailing list