[all-commits] [llvm/llvm-project] 85ee1d: Revert "Disable -Wmissing-prototypes for internal ...

David Blaikie via All-commits all-commits at lists.llvm.org
Wed Mar 9 13:13:22 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 85ee1d3ca1d06b6bd3477515b8d0c72c8df7c069
      https://github.com/llvm/llvm-project/commit/85ee1d3ca1d06b6bd3477515b8d0c72c8df7c069
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2022-03-09 (Wed, 09 Mar 2022)

  Changed paths:
    M clang/lib/Sema/SemaDecl.cpp
    M clang/test/SemaCXX/warn-missing-prototypes.cpp

  Log Message:
  -----------
  Revert "Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static""

Regresses:
typedef struct {
  static void  f() {
  }
} a_t;

Causing this to error instead of warn, because the linkage is computed
earlier/too early perhaps. I'll send out a review to see if there's some
other path forward or if this is an acceptable regression, etc.

This reverts commit 275c56226d7fbd6a4d554807374f78d323aa0c1c.




More information about the All-commits mailing list