[all-commits] [llvm/llvm-project] 0f622b: [libc++] Don't manually override NDEBUG in the dyl...

[Louis Dionne via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0f622bd281bda627cb988024bb1d86768d411e01
      https://github.com/llvm/llvm-project/commit/0f622bd281bda627cb988024bb1d86768d411e01
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2022-03-09 (Wed, 09 Mar 2022)

  Changed paths:
    M libcxx/CMakeLists.txt
    M libcxx/benchmarks/algorithms.bench.cpp

  Log Message:
  -----------
  [libc++] Don't manually override NDEBUG in the dylib build

LIBCXX_ENABLE_ASSERTIONS does not have any relationship to the `assert`
macro -- it only controls assertions that are internal to the library.
Playing around with `NDEBUG` only muddies the picture further than it
already is.

Also, remove a failing assertion in the benchmarks. That assertion had
never been exercised because we defined `NDEBUG` manually, and it was
failing since we introduced the ability to generate a benchmark vector
with the Quicksort adversary ordering (which is obviously not sorted).

This was split off of https://llvm.org/D121123.

Differential Revision: https://reviews.llvm.org/D121244